Skip to content

Commit

Permalink
In-memory collector: merge reports after upgrade
Browse files Browse the repository at this point in the history
Upgrading reports individually reduces the amount of upgrades, since some reports might have been upgraded in previously.
  • Loading branch information
Roberto Bruggemann committed Dec 12, 2017
1 parent e58f865 commit 50d039a
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion app/collector.go
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,13 @@ func (c *collector) Report(_ context.Context, timestamp time.Time) (report.Repor
c.clean()
c.quantise()

rpt := c.merger.Merge(c.reports).Upgrade()
upgradedReports := make([]report.Report, 0, len(c.reports))
for _, r := range c.reports {
upgradedReports = append(upgradedReports, r.Upgrade())
}
c.reports = upgradedReports

rpt := c.merger.Merge(c.reports)
c.cached = &rpt
return rpt, nil
}
Expand Down

0 comments on commit 50d039a

Please sign in to comment.