Try to figure out the most suitable shell to use #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. I think we need an integration test for this. |
2opremio
force-pushed
the
1053-use-default-shell
branch
from
cf6bbab to
7865fed
Compare
2opremio
force-pushed
the
1053-use-default-shell
branch
from
7865fed to
46b4fa3
Compare
|
@tomwilkie PTAL |
|
LGTM |
tomwilkie
added a commit
that referenced
this pull request
Mar 2, 2016
Try to figure out the most suitable shell to use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1053
Tested in busybox (no getent), alpine and ubuntu