Reorganise the render/ package #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwilkie
force-pushed
the
render-reorg
branch
4 times, most recently
from
f2fffb6 to
11b9a6f
Compare
tomwilkie
changed the title
tomwilkie
changed the title
| @@ -381,6 +382,7 @@ var ( | |||
| kubernetes.PodState: "running", | |||
| kubernetes.PodContainerIDs: ServerContainerID, | |||
| kubernetes.ServiceIDs: ServiceID, | |||
| report.HostNodeID: ServerHostNodeID, | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
The files in this seem structured to match the probes (docker, kubernetes, process). Thoughts about having one-file-per-target? i.e. making them match |
|
Discussed elsewhere, to rename the files according to "top-level" renderer (i.e. "process", "container", "pod", and "host"), then each file includes any sub-views (so ContainerHostname view goes in "container"). |
|
@paulbellamy PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim here is for no code changes, but to break down mapping.go and topology.go into separate files for each topology, which container both the mapping functions and the topology renderers.