Add scale up/down controls on deployments, replica sets, and replication controllers #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbellamy
force-pushed
the
scale-controls
branch
from
1cc74bd to
39a52f5
Compare
| @@ -326,3 +341,18 @@ func (r *Reporter) podTopology(services []Service, replicaSets []ReplicaSet) (re | |||
| }) | |||
| return pods, err | |||
| } | |||
|
|
|||
| func addScalingControls(t report.Topology) { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Looks good, but I think we might be able to make this more generic by using the Meta type in CaptureResource. Will think on it. |
Ah, maybe.. The tricky bit, at the moment, is mapping some "ReplicaSet" nodes back to replication controllers. Maybe that can be handled more gracefully, which would simplify CaptureResource. |
paulbellamy
force-pushed
the
scale-controls
branch
from
39a52f5 to
4cfbd59
Compare
I didn't think of a better way. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tomwilkie, ptal
Was debating adding a test for the
CaptureResourcemethod, as it's a bit involved.