circleci: push traffic control plugin image to docker hub #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this patch, circleci builds the traffic control plugin image and pushes it on docker hub. Rename traffic control plugin docker image to "weaveworks/scope-traffic-control-plugin".
alepuccetti
force-pushed
the
alessandro/tcd-circleci
branch
from
3e1735c to
66390c8
Compare
|
We've discussed where to put plugins, and decided that the scope repo is not the place for them (apart from the example plugins that are there for the purpose of being examples). I suggest to host them by the maintainer in their own repo, which also governs their CI (with upload to Docker hub). Once you've set up that repo, could you open a new issue here so we can link to it? From our side we'll add a bigger plugin section to this repo's readme where 3rd party plugins can be found. |
|
Apparently we decided differently. LGTM. I'll merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this patch, circleci builds the traffic control plugin image and
pushes it on docker hub. Rename traffic control plugin docker image
to "weaveworks/scope-traffic-control-plugin".