Node details spinner Chrome display bug fix #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpellizzari
reviewed
Feb 1, 2017
| // NOTE: If we start the fa-spin animation before the node details panel has been | ||
| // mounted, the spinner is displayed blurred the whole time in Chrome (possibly | ||
| // caused by a bug having to do with animating the details panel). | ||
| const spinnerClassName = classNames('fa fa-circle-o-notch', { 'fa-spin': this.props.mounted }); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Sorry for the delay on this review @fbarl. LGTM |
fbarl
force-pushed
the
details-spinner-display-fix
branch
3 times, most recently
from
610d596 to
75fdfec
Compare
fbarl
force-pushed
the
details-spinner-display-fix
branch
from
75fdfec to
2a8904e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2173.