Add very basic Docker Swarm service topology #2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't the best way to do it, but it will work well enough for an initial implementation
ekimekim
force-pushed
the
mike/docker-swarm/services-topology
branch
from
55f5766 to
2b20858
Compare
|
@2opremio since I don't have anyone around who can review this and I need it merged today, I'm just going to merge now. Could you please review when you're back? |
2opremio
reviewed
Apr 25, 2017
| @@ -50,7 +50,7 @@ func TestAPITopology(t *testing.T) { | |||
| } | |||
|
|
|||
| // TODO: add ECS nodes in report fixture | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
post-LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done in a very hacky way - we look at the container labels to identify the parent service,
and that's it. We can't see services that aren't running on that machine, and the only service info
we have is the name.