Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct type for "Observed Gen." #2572

Merged
merged 1 commit into from
Jun 8, 2017
Merged

correct type for "Observed Gen." #2572

merged 1 commit into from
Jun 8, 2017

Conversation

rade
Copy link
Member

@rade rade commented Jun 8, 2017

It's a number.

This enables numeric sorting of Observed Gen in the table mode of the Deployment and Replicaset views.

It's a number. This enables numeric sorting of Observed Gen in the
table mode of the Deployment and Replicaset views.
@rade rade requested a review from fbarl June 8, 2017 03:31
Copy link
Contributor

@fbarl fbarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rade rade merged commit 32735d8 into master Jun 8, 2017
@rade rade deleted the observed-gen-is-number branch July 5, 2017 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants