Add test for pods number not updating #2741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbarl
reviewed
Jul 25, 2017
| @@ -481,7 +481,8 @@ export function doLayout(immNodes, immEdges, opts) { | |||
|
|
|||
| if (layout) { | |||
| // Last line of defense - re-render everything if two nodes are too close to one another. | |||
| if (minEuclideanDistanceBetweenPoints(layout.nodes) < NODE_CENTERS_SEPARATION_FACTOR) { | |||
| if (layout.nodes.count() > 1 && | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| nodes = second.nodes.toJS(); | ||
| expect(nodes.n1.label).toEqual('lnew'); | ||
| expect(nodes.n1.labelMinor).toEqual('lmnew'); | ||
| expect(nodes.n1.rank).toEqual('rold'); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
rndstr
force-pushed
the
2401-pods-number-not-updating-on-labelMinor
branch
from
0c26d12 to
90995b9
Compare
rndstr
force-pushed
the
2401-pods-number-not-updating-on-labelMinor
branch
from
90995b9 to
66d490b
Compare
|
@fbarl good suggestions, mind taking another look? |
fbarl
reviewed
Jul 28, 2017
| }, | ||
| layoutProps: { | ||
| nodes: fromJS({ | ||
| n1: {id: 'n1', label: 'lold', labelMinor: 'lmold', rank: 'rold'}, |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2728