Small memory-allocation reduction #2872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We encode the zero time as an empty string, so we should do the reverse when decoding. Otherwise time.Parse() returns an error, which is created on the heap, causing extra garbage-collection load.
|
Seems like the compiler could be more clever when we assign the error to |
|
It's created inside |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When decoding a report with
Metricscontaining the zero timestamp, which we encode as an empty string, we are causingtime.Parseto return an error. That error object is created on the heap.Benchmarks (best time of five runs in each case):
Current master 46c5fca:
After 9322b54: