Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes "Save as svg" functionality. #2883

Merged
merged 1 commit into from
Oct 10, 2017
Merged

Fixes "Save as svg" functionality. #2883

merged 1 commit into from
Oct 10, 2017

Conversation

foot
Copy link
Contributor

@foot foot commented Oct 10, 2017

@foot foot requested a review from fbarl October 10, 2017 14:52
@rade
Copy link
Member

rade commented Oct 10, 2017

what broke this?

@foot
Copy link
Contributor Author

foot commented Oct 10, 2017

Some of our zoom unification stuff a185ae4

@foot
Copy link
Contributor Author

foot commented Oct 10, 2017

So yes unfortunately this has probably been broken for a while.

Making sentry noisier again would help perhaps. Will bring it up at next FE meeting.

fbarl
fbarl approved these changes Oct 10, 2017
View reviewed changes
Copy link
Contributor

@fbarl fbarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I should have been more careful with removing that ID :/

@foot foot merged commit 5173b9c into master Oct 10, 2017
@foot foot deleted the fixes-save-as-svg branch October 10, 2017 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbarl fbarl fbarl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@foot @rade @fbarl