don't map image adjacencies to hosts #2997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
approved these changes
Dec 20, 2017
rade
force-pushed
the
no-image-host-propagation
branch
from
ebe287c to
1fc4278
Compare
|
@bboreham PTAL. I reckon this is neater. There's a little bit of extra work in some cases but it does not involve any heap allocation and benchmarks show no difference in performance. I will squash the first two commits before merging. |
bboreham
approved these changes
Dec 21, 2017
rade
force-pushed
the
no-image-host-propagation
branch
from
1fc4278 to
724ea0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's just wrong