Prepare DOM for Guided Tours #3068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbarl
force-pushed
the
1861-prepare-dom-for-tours
branch
from
d631c4c to
a096c07
Compare
fbarl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laying the ground for interactive tours in Scope - https://github.com/weaveworks/service-ui/issues/1861.
Changes
babel-plugin-transform-class-propertiesin Scope to remove the need for annoying.bind(this)in constructors.ViewModeButtoncomponent for smarter rerendering, to make sure the tour step on view selectors survives the transition.onMouseUptoonClickevent on NodesGrid rows to catch clicking on the first row while it's focused in the tours.classNameto all the items in Topologies selector for anchoring tour steps to specific topologies..nodes-chart-overlaywhen transparent to get a better bounding box for the nodes graph for a tour step focus.Note to reviewers: It should suffice to take a look at the code and make sure nothing's broken. The Scope tour would appear available only after https://github.com/weaveworks/service-ui/pull/1944 has been merged. Any further configuration of the tour steps should be doable through the HelpHero service without touching the code.