Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce theme colors #3116

Merged
merged 9 commits into from
Mar 22, 2018
Merged

Enforce theme colors #3116

merged 9 commits into from
Mar 22, 2018

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented Mar 21, 2018 •
edited
Loading

Resolves #3115.

Changes
  • Added both stylelint for styled components and sass-lint for scss stylesheets and enforced the same rules as in service-ui repo (no use of literal CSS colors in particular).
  • Use only ui-components theme colors in stylesheets.

@fbarl fbarl self-assigned this Mar 21, 2018
@fbarl fbarl force-pushed the 3115-enforce-theme-colors branch from aef4fc3 to 80dd318 Compare March 21, 2018 09:40
@fbarl fbarl force-pushed the 3115-enforce-theme-colors branch from e387e71 to f121460 Compare March 21, 2018 11:29
@fbarl fbarl mentioned this pull request Mar 21, 2018
Merged
bia
bia previously approved these changes Mar 21, 2018
View reviewed changes
@bia bia dismissed their stale review March 21, 2018 11:44

confused with ui-components#152

@fbarl fbarl changed the title [WIP] Enforce theme colors Enforce theme colors Mar 21, 2018
@fbarl fbarl requested review from foot and bia March 21, 2018 15:05
bia
bia approved these changes Mar 22, 2018
View reviewed changes
Copy link
Contributor

@bia bia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are small colour changes, mainly to the shades of grey that I agree with.
screen shot 2018-03-22 at 12 33 43

foot
foot approved these changes Mar 22, 2018
View reviewed changes
Copy link
Contributor

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@fbarl fbarl merged commit 5f8da6d into master Mar 22, 2018
@fbarl fbarl deleted the 3115-enforce-theme-colors branch March 22, 2018 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bia bia bia approved these changes

@foot foot foot approved these changes

Assignees

@fbarl fbarl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbarl @foot @bia