Fixes monospace font overlapping in terminal+linux #3248
Conversation
|
I have just run this branch and my terminal is now not showing anything except cursor movement as I type; no characters are rendered at all. |
|
Works fine in Chrome though. Not FF. |
|
@rade thanks for testing! I will try something else... |
I got a linux env of virtualbox+ubuntu18.04+firefox59.0.2 and I can repro and fix. I've tried installing and removing roboto in the linux vm. It might be falling back to a strange default font on your machine now. I've popped in another font there as a bit of a hail mary, @rade could you please try testing this updated PR locally? |
|
Works fine now, though for some reason the first time I opened the terminal it was still blank. |
- Also fixes actually using Roboto-Mono, xterm.js now only accepts fontFamily customization via the JS api. (uses `<canvas`). - There is an issue (xtermjs/xterm.js#1170) if linux has to fall back to 'monospace' where things fail to render correctly, so provide a couple of common options so this rarely happens. - If we distribute robo-mono in the webpack bundle that might also work.
foot
force-pushed
the
fixes-scope-linux-term-issues
branch
from
1dbe145 to
7a04740
Compare
|
@jpellizzari not sure if you're on linux, but @rade and I verified that it works there. Code looks okay? |
Fixes #3245
I believe this fixes the linked issue but I haven't had a chance to test under linux yet..