Remove First and Last data members from Metrics structs #3266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They can be trivially computed when required.
Smaller structs = less garbage-collection = better performance.
This is a breaking change in the wire protocol; will need a version bump. New app will work with older probes, just ignoring the data.
I checked the JavaScript and can only find one use of the field, and that already falls back to the alternative.
Benchmarks (unmarshalling older reports which do contain the fields)
Before:
After:
The impact on
Merge()
is more noticeable when combined with #3253: