Fix ugorji/go's version #3280
Merged
Fix ugorji/go's version #3280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure what happened, but `gvt` is most likely buggy. Indeed, if you try to remove `ugorji/go/codec` and pull it again, with the revision listed in `vendor/manifest`, i.e.: ``` $ gvt delete github.com/ugorji/go/codec $ gvt fetch --revision c062049c1793b01a3cc3fe786108edabbaf7756b github.com/ugorji/go/codec YYYY/MM/DD HH:mm:SS Fetching: github.com/ugorji/go/codec ``` you then get the below build errors: ``` report/latest_map_generated.go:245:27: r.DecodeStringAsBytes undefined (type codec.decDriver has no field or method DecodeStringAsBytes) report/latest_map_generated.go:497:27: r.DecodeStringAsBytes undefined (type codec.decDriver has no field or method DecodeStringAsBytes) report/map_helpers.go:114:27: r.DecodeStringAsBytes undefined (type codec.decDriver has no field or method DecodeStringAsBytes) report/report.codecgen.go:191:14: r.DecodeStringAsBytes undefined (type codec.decDriver has no field or method DecodeStringAsBytes) report/report.codecgen.go:496:14: r.DecodeStringAsBytes undefined (type codec.decDriver has no field or method DecodeStringAsBytes) report/report.codecgen.go:803:14: r.DecodeStringAsBytes undefined (type codec.decDriver has no field or method DecodeStringAsBytes) report/report.codecgen.go:1001:14: r.DecodeStringAsBytes undefined (type codec.decDriver has no field or method DecodeStringAsBytes) report/report.codecgen.go:1240:14: r.DecodeStringAsBytes undefined (type codec.decDriver has no field or method DecodeStringAsBytes) report/report.codecgen.go:1567:14: r.DecodeStringAsBytes undefined (type codec.decDriver has no field or method DecodeStringAsBytes) report/report.codecgen.go:1858:14: r.DecodeStringAsBytes undefined (type codec.decDriver has no field or method DecodeStringAsBytes) report/report.codecgen.go:1858:14: too many errors Makefile:104: recipe for target 'render/detailed/detailed.codecgen.go' failed ``` which I also got in another project importing Scope. This is fixed by running the following: ``` $ gvt delete github.com/ugorji/go/codec $ gvt fetch --revision 54210f4e076c57f351166f0ed60e67d3fca57a36 github.com/ugorji/go/codec YYYY/MM/DD HH:mm:SS Fetching: github.com/ugorji/go/codec ``` Note that this revision was found in previous commit messages: ``` $ git log -S ugorji [...] commit 42bf0de Author: Bryan Boreham <bjboreham@gmail.com> Date: Sat Sep 23 21:08:33 2017 +0000 Update ugorji/go/codec to latest commit 54210f4e076c57f351166f0ed60e67d3fca57a36 [...] ```
|
Seems quite likely to me that the problem was that #2863 didn't update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what happened (
gvtmay be buggy?).Indeed, if you try to remove
ugorji/go/codecand pull it again, with the revision listed invendor/manifest, i.e.:you then get the below build errors:
which I also got in another project importing Scope.
This is fixed by running the following:
Note that this revision was found in previous commit messages: