Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import missing terminal.scss in contrast.scss #3347

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

rake7h
Copy link
Contributor

@rake7h rake7h commented Sep 14, 2018

import terminal.scss in contrast.scss which is missing currently and causing the terminal styling in contrast mode.

Before:
screen shot 2018-09-14 at 12 09 19 pm

After:
screen shot 2018-09-14 at 3 03 03 pm

fixes: #3346

@rade rade requested a review from fbarl September 14, 2018 09:55
Copy link
Contributor

@fbarl fbarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! 👍

@satyamz
Copy link
Contributor

satyamz commented Sep 14, 2018

@fbarl Can you please restart the build for integration-tests ?

@leth
Copy link
Contributor

leth commented Sep 19, 2018

I've re-run the build a couple of times. If that doesn't resolve the build issue for you perhaps try rebasing against master.

@bboreham
Copy link
Collaborator

Note it is (currently) necessary for a maintainer to push the branch to the Weaveworks repo for the integration tests to run properly. I have just done that.

@bboreham bboreham merged commit 2df731b into weaveworks:master Sep 25, 2018
@bboreham
Copy link
Collaborator

Tests passed - merged.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminal shows extra text area when in contrast mode
5 participants