Probes POST to apps #342
Merged
Probes POST to apps #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| router := mux.NewRouter() | ||
| post := router.Methods("POST").Subrouter() | ||
| post.HandleFunc("/", handleReport(c)) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
For the OSS to work, doesn't the probe need to use the resolver to publish to multiple apps? |
| @@ -25,10 +25,11 @@ var version = "dev" // set at build time | |||
|
|
|||
| func main() { | |||
| var ( | |||
| publish = flag.String("publish", fmt.Sprintf("http://localhost:%d", xfer.AppPort), "URL to publish reports") | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
peterbourgon
force-pushed
the
reverse-publish
branch
4 times, most recently
from
75f6fc5 to
9099b2a
Compare
- App takes POST report on /api/report - Probe publishes to configured target(s) - Name resolution happens on probe-side - There's no longer an xfer.ProbePort - xfer.Collector responsibility is reduced - Fixes to remaining experimental components. - rm experimental/bridge: it's not being used, and by changing the app/probe comm model, it would require a complete refactor anyway. We can easily rebuild it when we need to. It will even be much simpler. - rm experimental/graphviz: it's broken for some time anyway, and we don't really need to play around with it as a rendering option anymore. - rm experimental/oneshot: we never use this anymore.
peterbourgon
force-pushed
the
reverse-publish
branch
from
b657ec1 to
7d51f17
Compare
|
@tomwilkie @paulbellamy @2opremio Ready for review! |
| p.closer.Close() | ||
| // AuthorizationHeader returns a value suitable for an HTTP Authorization | ||
| // header, based on the passed token string. | ||
| func AuthorizationHeader(token string) string { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Overall, LGTM |
peterbourgon
force-pushed
the
reverse-publish
branch
from
dec70e8 to
a8d3fdf
Compare
peterbourgon
force-pushed
the
reverse-publish
branch
from
a8d3fdf to
edf0ceb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the flow of the streams.