Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adjacency between Pod and PVC when claim name and namespace are same #3530

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

qiell
Copy link
Contributor

@qiell qiell commented Dec 8, 2018

  • Name of the PVC can be the same in different namespaces, in this
    scenario an application pod is connected to multiple PVC.
    screenshot from 2018-12-07 22-46-05

  • Add adjacency between Pod and PVC when claim name and namespace are same.

Signed-off-by: Akash Srivastava akash.srivastava@openebs.io

- Name of the PVC can be same in different namespaces, in this
scenario an application pod is connected to multiple PVC.

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
@fbarl
Copy link
Contributor

fbarl commented Dec 11, 2018

@bboreham would you mind reviewing this one?

@fbarl fbarl requested a review from bboreham December 11, 2018 17:17
@qiell qiell changed the title Check Pod and PVC namespace while rendering Add adjacency between Pod and PVC when claim name and namespace are same Dec 11, 2018
Copy link
Contributor

@satyamz satyamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bboreham bboreham merged commit 9803fff into weaveworks:master Dec 13, 2018
@bboreham bboreham mentioned this pull request Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants