Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update xterm.js dependency (CVE-2019-0542) #3557

Merged
merged 1 commit into from
Feb 4, 2019
Merged

update xterm.js dependency (CVE-2019-0542) #3557

merged 1 commit into from
Feb 4, 2019

Conversation

dholbach
Copy link
Contributor

@dholbach dholbach requested a review from fbarl January 15, 2019 10:44
@dholbach
Copy link
Contributor Author

Hum. This is probably not as straight-forward as I thought.

Now that I retried it in a local build and running scope launch, it works only the second time (clicking on host to start a shell there), the first time the screen is blank.

@dholbach
Copy link
Contributor Author

Looks like my last comment is an unrelated problem which happens with xterm.js 3.3.0, 3.8.1 and 3.10.1. I'll file a separate issue for this.

@dholbach dholbach mentioned this pull request Jan 15, 2019
Open
@dholbach
Copy link
Contributor Author

Tried it on minikube (built locally, pushed image to dockerhub, pointed k8s deployment to those images). The first launch of a shell in a container came up blank (as in #3559), this is with the current PR (using xterm.js 3.8.1). I can't say I'm confident in this change now.

Help wanted, setting back to WIP.

@dholbach dholbach added the mystery We don't know what could be causing this label Jan 15, 2019
@dholbach dholbach changed the title update xterm.js dependency (CVE-2019-0542) WIP: update xterm.js dependency (CVE-2019-0542) Jan 15, 2019
@dholbach dholbach requested a review from foot January 16, 2019 04:28
@foot
Copy link
Contributor

foot commented Jan 16, 2019

Having a quick look...

foot
foot approved these changes Jan 16, 2019
View reviewed changes
Copy link
Contributor

@foot foot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Under firefox sometimes the first time you open a terminal it stays blank even after input.
  • As noted this is not a regression and also happens on master

update xterm.js dependency (CVE-2019-0542)
32b85e6 
Signed-off-by: Daniel Holbach <daniel@weave.works>
@dholbach
Copy link
Contributor Author

Let's go with 3.10.1 then. It fixes a number of bugs and is faster. Originally I wanted to just update to the closest, unaffected version, but since the behaviour is the same between all versions, let's go with the most recent.

@dholbach dholbach removed the mystery We don't know what could be causing this label Jan 17, 2019
@dholbach dholbach changed the title WIP: update xterm.js dependency (CVE-2019-0542) update xterm.js dependency (CVE-2019-0542) Jan 21, 2019
@bboreham bboreham merged commit 0c3f565 into master Feb 4, 2019
@bboreham bboreham deleted the update-xterm branch February 4, 2019 16:45
@bboreham bboreham mentioned this pull request Feb 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foot foot foot approved these changes

@fbarl fbarl Awaiting requested review from fbarl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dholbach @foot @bboreham