Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ui-cmp and some of similar deps #3574

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Upgrade ui-cmp and some of similar deps #3574

merged 1 commit into from
Feb 27, 2019

Conversation

foot
Copy link
Contributor

@foot foot commented Feb 27, 2019

  • So everyone is on the same styled-components
  • Only visual diff found: terminal font is a bit heavier

@foot
Upgrade ui-cmp and some of similar deps
e07c67a 
- So everyone is on the same styled-components
- Only visual diff found: terminal font is a bit heavier
@foot foot requested a review from fbarl February 27, 2019 01:32
@foot
Copy link
Contributor Author

foot commented Feb 27, 2019

@fbarl any conflicts / concerns come to mind? Everything seems to work.

fbarl
fbarl approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@fbarl fbarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

I went quickly through the changelog of ui-components and the only changes that are reflected here are some minor padding adjustments in Search and TimeTravel components.

Tested it as standalone and in Weave Cloud and all seems to work fine!

@foot foot merged commit e6da961 into master Feb 27, 2019
@foot foot deleted the upgrade-ui-cmp-0191 branch February 27, 2019 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbarl fbarl fbarl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foot @fbarl