Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build-pkg script #3587

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Fix build-pkg script #3587

merged 1 commit into from
Mar 26, 2019

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented Mar 26, 2019

Follow-up to #3580.

This change makes babel in build-pkg script fully transform the JS files to make them more compatible when imported from Weave Cloud.

@fbarl fbarl self-assigned this Mar 26, 2019
@fbarl fbarl requested a review from foot March 26, 2019 15:31
foot
foot approved these changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️

@foot
Copy link
Contributor

foot commented Mar 26, 2019

Setting this to false will not transform modules.

@foot
Copy link
Contributor

foot commented Mar 26, 2019

https://babeljs.io/docs/en/babel-preset-env#modules

@fbarl fbarl merged commit 68a1278 into master Mar 26, 2019
@fbarl fbarl deleted the fix-babel-pkg-builds branch March 26, 2019 15:51
@Deepak1100 Deepak1100 mentioned this pull request Mar 27, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foot foot foot approved these changes

Assignees

@fbarl fbarl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbarl @foot