Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenTracing span for report.ReadBinary() #3598

Merged
merged 1 commit into from
May 15, 2019
Merged

Add OpenTracing span for report.ReadBinary() #3598

merged 1 commit into from
May 15, 2019

Conversation

bboreham
Copy link
Collaborator

So we can see the timing and size in Jaeger.

@bboreham
Add OpenTracing span for report.ReadBinary()
711aa66 
So we can see the timing and size in Jaeger.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
fbarl
fbarl approved these changes May 15, 2019
View reviewed changes
Copy link
Contributor

@fbarl fbarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Was this in any way motivated by #3597 (comment)?

satyamz
satyamz approved these changes May 15, 2019
View reviewed changes
Copy link
Contributor

@satyamz satyamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@bboreham
Copy link
Collaborator Author

Was this in any way motivated by #3597 (comment)?

No, that's much better addressed by the probe metrics I found (and am changing in #3600).

This span is on the read side, i.e. in the app or collector.

@bboreham bboreham merged commit 474ada4 into master May 15, 2019
@bboreham bboreham deleted the readbinary-span branch May 15, 2019 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satyamz satyamz satyamz approved these changes

@fbarl fbarl fbarl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bboreham @fbarl @satyamz