Only group processes not in containers AND doing network IO into uncontained nodes. #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwilkie
force-pushed
the
uncontainer-all-processes
branch
from
11cdf98 to
e7e4648
Compare
tomwilkie
force-pushed
the
master
branch
2 times, most recently
from
66be8bd to
d9ab9d8
Compare
| } | ||
| } | ||
| return output | ||
| } |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
tomwilkie
force-pushed
the
uncontainer-all-processes
branch
from
e7e4648 to
705d1ed
Compare
|
Simple enough. Looks like the new Filter is unit tested by the detailed_node_test? If so, 👍 |
tomwilkie
force-pushed
the
uncontainer-all-processes
branch
from
705d1ed to
fdd1030
Compare
|
This now includes a fix for #403 - by construction, we only include edges from the endpoint topology once, guaranteeing we don't over count the edgemetadata. |
tomwilkie
force-pushed
the
uncontainer-all-processes
branch
from
fdd1030 to
e7dc258
Compare
|
It's difficult to follow the rendering pipeline. I wish for something more procedural. That said, I can understand what's happening here. LGTM. |
tomwilkie
added a commit
that referenced
this pull request
Aug 27, 2015
Only group processes not in containers AND doing network IO into uncontained nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the re-enablement of the selection of pseudo nodes (#249), it turns out our 'Uncontained' nodes in the containers view contains all processes. This isn't particularly useful; we only want to show the 'Uncontained' node if there is a process on the machine with network connections with isn't in a container.
The changes to the bandwidth figures are due to #373, which is not a big deal right now as the bandwidth figures aren't enabled by default, but I'll fix that next.