Correctly extract image name when using custom hub.

[tomwilkie]

Fixes #820

[paulbellamy]

I'd like to see a few tests for ones which are already without a version.

[paulbellamy]

also, that regex is awful.

[tomwilkie]

I'd like to see a few tests for ones which are already without a version.

AFAICT the docker API will never give you images without versions. This regex expects a version.

also, that regex is awful.

Awfully good? :-) But seriously, whats awful about it? I might remove the names matches, but otherwise it seems pretty minimal and robust.

[paulbellamy]

Also, images don't have to have a slash in them, do they?

[2opremio]

Also, images don't have to have a slash in them, do they?

Very true, ubuntu, busybox etc ...

[paulbellamy]

This regex expects a version.

One of the assumptions I had when writing #752, was that this function is idempotent. It shouldn't break anything, but would be nice to maintain that if possible.

[tomwilkie]

Very true, ubuntu, busybox etc ...

Actually those ones do (they come from library/busybox)

But images you make locally won't, so that does need fixing. Unfortunately I think that makes parsing non-deterministic (how to differentiate from hostname/foo vs org/foo). I guess something like "first split on slash, if 2 -> first is org, if 3 -> first is repo" might work?

One of the assumptions I had when writing #752, was that this function is idempotent. It shouldn't break anything, but would be nice to maintain that if possible.

I see - so you want versions to be optional. Thats totally possible.

[tomwilkie]

@paulbellamy PTAL

[paulbellamy]

LGTM