Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container uptime and restart count to details panel. #853

Merged
merged 1 commit into from
Feb 1, 2016

Conversation

tomwilkie
Copy link
Contributor

Fixes #844

@paulbellamy
Copy link
Contributor

Container uptime is very specific (e.g. 3h0m9.382506493s). Let's truncate it to seconds.

Restarts seems to always be 0.. Does it only count restart policy restarts? Does it only work if there is a restart policy?

@tomwilkie tomwilkie force-pushed the 844-container-uptime branch 2 times, most recently from d8f7f39 to 28a3717 Compare January 27, 2016 21:29
@tomwilkie
Copy link
Contributor Author

Container uptime is very specific (e.g. 3h0m9.382506493s). Let's truncate it to seconds.

Fixed

Restarts seems to always be 0.. Does it only count restart policy restarts? Does it only work if there is a restart policy?

This I do not know. I couldn't get it to != 0. Needs more work.

@tomwilkie
Copy link
Contributor Author

Actually works fine:

screen shot 2016-01-27 at 19 30 59

It only shows restarts due to restart policy, so doing this:

docker run -dti --restart=always alpine /bin/sh

And then killing the /bin/sh increments the counter.

@tomwilkie tomwilkie force-pushed the 844-container-uptime branch from 28a3717 to 638c567 Compare January 29, 2016 22:32
paulbellamy added a commit that referenced this pull request Feb 1, 2016
Add container uptime and restart count to details panel.
@paulbellamy paulbellamy merged commit 7601a34 into master Feb 1, 2016
@paulbellamy paulbellamy deleted the 844-container-uptime branch February 1, 2016 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants