Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some fields overflowing badly. #892

Merged
merged 1 commit into from
Feb 1, 2016

Conversation

foot
Copy link
Contributor

@foot foot commented Feb 1, 2016

The Chrome guys have implmeneted a new change (in Chrome 48) in the CSS
flexbox spec, min-width now defaults to auto instead of 0. "auto" has
some complicated behaviour described in the table here:
https://drafts.csswg.org/css-flexbox/#min-size-auto

This results in a very long min-width (I don't understand why). So we
have to let the browser know it can make it smaller if it wants to,
which in this case would be great.

Here's another person's experience with the issue.

Fixes #864

The Chrome guys have implmeneted a new change (in Chrome 48) in the CSS
flexbox spec, min-width now defaults to auto instead of 0. "auto" has
some complicated behaviour described in the table here:
https://drafts.csswg.org/css-flexbox/#min-size-auto

This results in a very long min-width (I don't understand why). So we
have to let the browser know it can make it smaller if it wants to,
which in this case would be great.

Here's another person's experience with the issue.
 - https://code.google.com/p/chromium/issues/detail?id=551336
@tomwilkie tomwilkie mentioned this pull request Feb 1, 2016
@davkal
Copy link
Contributor

davkal commented Feb 1, 2016

LGTM

foot added a commit that referenced this pull request Feb 1, 2016
…anel

Fixes some fields overflowing badly.
@foot foot merged commit 6bec4bc into master Feb 1, 2016
@foot foot deleted the 864-fix-overflowing-details-panel branch February 1, 2016 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants