-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gather file descriptors as process metric #961
Conversation
325d630
to
5bb3d49
Compare
I think it's a very useful metric, but I am not convinced it should have On Friday, February 12, 2016, Paul Bellamy notifications@github.com wrote:
|
Yes it would be good to have this hidden behind a show more. On Friday, 12 February 2016, Alfonso Acosta notifications@github.com
|
@paulbellamy From my own debugging experience, open files gets you straight into root cause analysis, whereas cpu and memory are quite vague. so I love its prominence there (until a better metric comes along). |
Tried the branch, JS part looks good too. |
@@ -83,6 +88,11 @@ func (w *walker) Walk(f func(Process, Process)) error { | |||
continue | |||
} | |||
|
|||
fileDescriptors, err := readFileDescriptors(path.Join(w.procRoot, filename, "fd")) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
minor-comments aside, LGTM |
Gather file descriptors as process metric
Fixes #729
Any other bits we should to gather? I'm not super-convinced it's actually all that useful?
@2opremio, wdyt?
See "Open Files" sparkline below.