Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gather file descriptors as process metric #961

Merged
merged 2 commits into from
Feb 17, 2016
Merged

Conversation

paulbellamy
Copy link
Contributor

Fixes #729

Any other bits we should to gather? I'm not super-convinced it's actually all that useful?

@2opremio, wdyt?

See "Open Files" sparkline below.
screen shot 2016-02-12 at 17 03 39

@2opremio
Copy link
Contributor

I think it's a very useful metric, but I am not convinced it should have
such protagonism, or whether it's useful to show in a
sparkline.

On Friday, February 12, 2016, Paul Bellamy notifications@github.com wrote:

Assigned #961 #961 to @2opremio
https://github.com/2opremio.


Reply to this email directly or view it on GitHub
#961 (comment).

@tomwilkie
Copy link
Contributor

Yes it would be good to have this hidden behind a show more.

On Friday, 12 February 2016, Alfonso Acosta notifications@github.com
wrote:

I think it's a very useful metric, but I am not convinced it should have
such protagonism, or whether it's useful to show it it's history in a
sparkline.

On Friday, February 12, 2016, Paul Bellamy <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

Assigned #961 #961 to
@2opremio
https://github.com/2opremio.


Reply to this email directly or view it on GitHub
#961 (comment).


Reply to this email directly or view it on GitHub
#961 (comment).

@paulbellamy
Copy link
Contributor Author

Hiding a single element seems stupid.

Edit: However, I agree that it is less important. Thoughts, @davkal, @foot ?

@davkal
Copy link
Contributor

davkal commented Feb 15, 2016

@paulbellamy From my own debugging experience, open files gets you straight into root cause analysis, whereas cpu and memory are quite vague. so I love its prominence there (until a better metric comes along).

@davkal
Copy link
Contributor

davkal commented Feb 15, 2016

Tried the branch, JS part looks good too.

@@ -83,6 +88,11 @@ func (w *walker) Walk(f func(Process, Process)) error {
continue
}

fileDescriptors, err := readFileDescriptors(path.Join(w.procRoot, filename, "fd"))

This comment was marked as abuse.

@2opremio
Copy link
Contributor

minor-comments aside, LGTM

@2opremio 2opremio assigned paulbellamy and unassigned 2opremio Feb 15, 2016
paulbellamy added a commit that referenced this pull request Feb 17, 2016
Gather file descriptors as process metric
@paulbellamy paulbellamy merged commit 611f933 into master Feb 17, 2016
@paulbellamy paulbellamy deleted the 729-open-fds-metric branch February 17, 2016 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants