Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gather and rename neutral colors #273

Closed
fbarl opened this issue Jun 19, 2018 · 3 comments
Closed

Gather and rename neutral colors #273

fbarl opened this issue Jun 19, 2018 · 3 comments
Assignees
@fbarl
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality style-guide Part of the effort towards a unified design system

Comments

@fbarl
Copy link
Contributor

fbarl commented Jun 19, 2018

In the spirit of #259 and #265, we should rename neutral colors to grayXXX (except white and black):

image

  • status.disabled is currently used in only one place in Service UI and it should probably be replaced with purple400 there, so that color can be removed
  • It would be nice to add one more shade of gray between silver and gallery for some Scope backgrounds
@fbarl fbarl added chore Related to fix/refinement/improvement of end user or new/existing developer functionality style-guide Part of the effort towards a unified design system labels Jun 19, 2018
@fbarl fbarl self-assigned this Jun 19, 2018
@bia
Copy link
Contributor

bia commented Jun 20, 2018

Agree with both of your points.

The status colors themselves might also be renamed when we address them in #178.

This was referenced Jun 20, 2018
Closed
Merged
Merged
@fbarl fbarl closed this as completed Jun 22, 2018
@jml
Copy link

jml commented Jun 25, 2018

Does this impact the user in any way? How does this relate to #260?

@fbarl
Copy link
Contributor Author

fbarl commented Jun 25, 2018

@jml It has a negligible user impact, so I think you can skip it for the report. #260 on the other hand massively reduced the number of shades of grays we use in our app (from 17 down to 6 including black and white).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbarl fbarl

Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality style-guide Part of the effort towards a unified design system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bia @jml @fbarl