Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename some colors to be more obvious #218

Closed
bia opened this issue May 16, 2018 · 3 comments
Closed

Rename some colors to be more obvious #218

bia opened this issue May 16, 2018 · 3 comments
Assignees
@fbarl
Labels
style-guide Part of the effort towards a unified design system

Comments

@bia
Copy link
Contributor

bia commented May 16, 2018

Talking with @miklosp, we thought that some of the colors should be given more boring names than the auto-generated ones to make them more legible.

For example, #5b5b88 comet could be #5b5b88 cometPurple instead.
It is however not nice that the names become longer. Please post any suggestions.
@miklosp
Copy link

miklosp commented May 16, 2018

Just "purple"? Variants could be purple-dark, purple-light, purple-xlight, etc...

@bia
Copy link
Contributor Author

bia commented May 16, 2018

There are 15 purples and 16 greys. Perhaps more colours should be pruned before renaming.

@fbarl fbarl added the style-guide Part of the effort towards a unified design system label Jun 13, 2018
@fbarl fbarl self-assigned this Jun 18, 2018
@fbarl fbarl mentioned this issue Jun 18, 2018
Merged
@fbarl
Copy link
Contributor

fbarl commented Jun 20, 2018

Basically addressed by #273, #265 and #259.

@fbarl fbarl closed this as completed Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbarl fbarl

Labels
style-guide Part of the effort towards a unified design system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bia @fbarl @miklosp