-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapse purple theme colors #262
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbarl
force-pushed
the
259-collapse-purple-colors
branch
from
June 18, 2018 13:22
c3b3b12
to
be61639
Compare
fbarl
force-pushed
the
259-collapse-purple-colors
branch
from
June 18, 2018 13:23
be61639
to
2f29229
Compare
fbarl
changed the title
[WIP] Collapse purple theme colors
Collapse purple theme colors
Jun 18, 2018
foot
reviewed
Jun 18, 2018
docs/js/Example.js
Outdated
background-color: ${props => props.theme.colors.athens}; | ||
color: ${props => props.theme.colors.gunpowder}; | ||
background-color: ${props => props.theme.colors.primary.purple100}; | ||
color: ${props => props.theme.colors.purple800}; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
foot
approved these changes
Jun 18, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! LGTM
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI components part of #259.
After some tiny normalizations, the primary colors spectrum consists of the following colors (rough usage estimates in brackets):
hsl(240, 20%, 25%) - charcoal (20)
hsl(240, 20%, 30%) - gunpowder (22)
hsl(240, 20%, 35%) - mulledWine (4)
hsl(240, 20%, 42%) - cometDark (1)
hsl(240, 20%, 45%) - comet (3)
hsl(240, 20%, 49%) - kimberlyDark (4)
hsl(240, 20%, 57%) - kimberly (7)
hsl(240, 20%, 59%) - lavender (44)
hsl(240, 20%, 65%) - amethystSmoke (14)
hsl(240, 20%, 75%) - logan (6)
hsl(240, 20%, 79%) - blueHaze (5)
hsl(240, 20%, 90%) - mischka (9)
hsl(240, 20%, 91%) - athens (10)
hsl(240, 20%, 95%) - athensGray (6)
hsl(240, 20%, 98%) - whiteSmoke (14)
New color system (dropped 4 colors from above):
hsl(240, 20%, 25%) - purple900
hsl(240, 20%, 30%) - purple800
hsl(240, 20%, 35%) - purple700
hsl(240, 20%, 45%) - purple600
hsl(240, 20%, 50%) - purple500
hsl(240, 20%, 60%) - purple400
hsl(240, 20%, 65%) - purple300
hsl(240, 20%, 75%) - purple200
hsl(240, 20%, 90%) - purple100
hsl(240, 20%, 95%) - purple50
hsl(240, 20%, 98%) - purple25
The naming convention was inspired by Material Design and the discussion in #218.
cc @bia @miklosp
Note: I also added the default tooltip info on the colors preview page and relaxed the saturation sorting criterion a bit.