Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse purple theme colors #262

Merged
merged 4 commits into from
Jun 18, 2018
Merged

Collapse purple theme colors #262

merged 4 commits into from
Jun 18, 2018

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented Jun 14, 2018

UI components part of #259.

After some tiny normalizations, the primary colors spectrum consists of the following colors (rough usage estimates in brackets):

hsl(240, 20%, 25%) - charcoal (20)
hsl(240, 20%, 30%) - gunpowder (22)
hsl(240, 20%, 35%) - mulledWine (4)
hsl(240, 20%, 42%) - cometDark (1)
hsl(240, 20%, 45%) - comet (3)
hsl(240, 20%, 49%) - kimberlyDark (4)
hsl(240, 20%, 57%) - kimberly (7)
hsl(240, 20%, 59%) - lavender (44)
hsl(240, 20%, 65%) - amethystSmoke (14)
hsl(240, 20%, 75%) - logan (6)
hsl(240, 20%, 79%) - blueHaze (5)
hsl(240, 20%, 90%) - mischka (9)
hsl(240, 20%, 91%) - athens (10)
hsl(240, 20%, 95%) - athensGray (6)
hsl(240, 20%, 98%) - whiteSmoke (14)


New color system (dropped 4 colors from above):

hsl(240, 20%, 25%) - purple900
hsl(240, 20%, 30%) - purple800
hsl(240, 20%, 35%) - purple700
hsl(240, 20%, 45%) - purple600
hsl(240, 20%, 50%) - purple500
hsl(240, 20%, 60%) - purple400
hsl(240, 20%, 65%) - purple300
hsl(240, 20%, 75%) - purple200
hsl(240, 20%, 90%) - purple100
hsl(240, 20%, 95%) - purple50
hsl(240, 20%, 98%) - purple25

image

The naming convention was inspired by Material Design and the discussion in #218.

cc @bia @miklosp


Note: I also added the default tooltip info on the colors preview page and relaxed the saturation sorting criterion a bit.

@fbarl fbarl self-assigned this Jun 14, 2018
@fbarl fbarl force-pushed the 259-collapse-purple-colors branch from c3b3b12 to be61639 Compare June 18, 2018 13:22
@fbarl fbarl force-pushed the 259-collapse-purple-colors branch from be61639 to 2f29229 Compare June 18, 2018 13:23
@fbarl fbarl changed the title [WIP] Collapse purple theme colors Collapse purple theme colors Jun 18, 2018
@fbarl fbarl requested review from foot and bia June 18, 2018 13:27
@fbarl fbarl mentioned this pull request Jun 18, 2018
@fbarl fbarl mentioned this pull request Jun 18, 2018
background-color: ${props => props.theme.colors.athens};
color: ${props => props.theme.colors.gunpowder};
background-color: ${props => props.theme.colors.primary.purple100};
color: ${props => props.theme.colors.purple800};

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

Copy link
Contributor

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! LGTM

@miklosp
Copy link

miklosp commented Jun 18, 2018

LGTM!

@fbarl fbarl merged commit 17421d6 into master Jun 18, 2018
@fbarl fbarl deleted the 259-collapse-purple-colors branch June 18, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants