Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply standard spacing across all components #424

Closed
8 tasks
fbarl opened this issue Nov 22, 2018 · 5 comments
Closed
8 tasks

Apply standard spacing across all components #424

fbarl opened this issue Nov 22, 2018 · 5 comments
Assignees
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality style-guide Part of the effort towards a unified design system

Comments

@fbarl
Copy link
Contributor

fbarl commented Nov 22, 2018

Follow-up on #400 - probably it makes sense starting with large sizes down to small ones:

  • 64px xxl
  • 48px xl
  • 32px large
  • 24px base medium
  • 16px small base
  • 12px small
  • 8px xs
  • 4px mini xxs
@fbarl fbarl added chore Related to fix/refinement/improvement of end user or new/existing developer functionality style-guide Part of the effort towards a unified design system labels Nov 22, 2018
@bia
Copy link
Contributor

bia commented Nov 22, 2018

I would go with xxs instead of mini to avoid confusion.

@bia
Copy link
Contributor

bia commented Nov 22, 2018

We'll address #324 within the scope of this issue.
cc @guyfedwards

@rndstr
Copy link
Contributor

rndstr commented Nov 27, 2018

base

my 2c: is base being used anywhere else? this seems more like a default to me. base tells me that's the value we are basing all the others on which could be something completely different than the 'usual' value to use.

maybe we can name it medium instead to go with the sizing names of the others?

@bia
Copy link
Contributor

bia commented Nov 27, 2018

@rndstr But at this point we are basing all of the other values on the base.
From #432 :
dsjh6wxuwaafslu

@rndstr
Copy link
Contributor

rndstr commented Nov 27, 2018

@bia that makes totally sense then, thanks for explaining!

Should we also define them in relation to base then instead of hardcoding?

export const spacing = {
none: '0',
xss: '4px',
xs: '8px',
small: '16px',
base: '24px',
large: '48px',
xl: '64px',
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality style-guide Part of the effort towards a unified design system
Projects
None yet
Development

No branches or pull requests

3 participants