Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardising line heights throughout components to match spacing #441

Open
bia opened this issue Dec 6, 2018 · 1 comment
Open

Standardising line heights throughout components to match spacing #441

bia opened this issue Dec 6, 2018 · 1 comment
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality needs-discussion Issue is a question or a proposal that needs discussion

Comments

@bia
Copy link
Contributor

bia commented Dec 6, 2018

Builds upon #424, line heights of fonts are sporadically set in some but not most components which have text.

cc @miklosp

After quite some research, it seems best to implement a line height relative to font size of 1.618 throughout the entire app instead. @fbarl what is the best way to override this everywhere?

@bia bia added the chore Related to fix/refinement/improvement of end user or new/existing developer functionality label Dec 6, 2018
@bia bia added the needs-discussion Issue is a question or a proposal that needs discussion label Dec 20, 2018
@fbarl
Copy link
Contributor

fbarl commented Jan 14, 2019

Sounds good to me!

According to the article, it should be enough to add that one line of CSS somewhere at the top of our app (probably in service-ui rather than here) and then make sure we remove all the rest of line-heights from the styles. We could probably even add line-height to the stylelint blacklist to forbid the overrides: https://stylelint.io/user-guide/rules/property-blacklist/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality needs-discussion Issue is a question or a proposal that needs discussion
Projects
None yet
Development

No branches or pull requests

2 participants