Skip to content

Commit

Permalink
adding adr
Browse files Browse the repository at this point in the history
  • Loading branch information
enekofb committed Sep 26, 2022
1 parent bb0dc4a commit 914c685
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 13 deletions.
4 changes: 3 additions & 1 deletion docs/adrs/0011-pipelines.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ Approved
## Context

As part of weave gitops, Sunglow team is working on deliverying Continuous Delivery Pipelines based in the following
[initiative](https://www.notion.so/weaveworks/CD-Pipeline-39a6df44798c4b9fbd140f9d0df1212a)
[initiative](https://www.notion.so/weaveworks/CD-Pipeline-39a6df44798c4b9fbd140f9d0df1212a).

First version

The past week has been used for doing discovery on designing a solution that could help us working in the context
of the two main milestones named as (0.1) and (1.0).
Expand Down
40 changes: 28 additions & 12 deletions docs/adrs/0013-pipelines-change-detection.md
Original file line number Diff line number Diff line change
@@ -1,27 +1,43 @@
# 12. Pipeline Promotions
# 13. Pipelines - How to detect deployment changes

## Status

Discovery in progress. This ADR currently is only to raise a draft PR to gather feedback.
Proposed

## Context
As part of weave gitops, Sunglow is working on delivering [Continuous Delivery Pipelines](https://www.notion.so/weaveworks/CD-Pipeline-39a6df44798c4b9fbd140f9d0df1212a)

As part of weave gitops, Sunglow team is working on deliverying Continuous Delivery Pipelines based in the following
[initiative](https://www.notion.so/weaveworks/CD-Pipeline-39a6df44798c4b9fbd140f9d0df1212a)

First iteration (v0.1) has covered the ability to view an application being deployed across different environments.
It's [first version (v0.1)](//TODO add link) has been delivered covering the ability to view an application deployed across different environments.

Current iteration (v0.2) has a outcome to enable applicatio promotions by using weave gitops enteprrise
The [second iteration](//TODO) aims to enable integration with internal and external promotions.

Two main approaches are under discussion
As part of the promotions capabilities, there is the need to detect when a deployment has occurred with not only
an approach to do it. During the discovery of the second iteration, two models has been spiked:

- [Promotions via Resource Watching](https://github.com/weaveworks/weave-gitops-enterprise/issues/1481)
- [Promotions via Webhooks](https://github.com/weaveworks/weave-gitops-enterprise/issues/1487)
Detect deployment changes via

- [Watching](https://github.com/weaveworks/weave-gitops-enterprise/issues/1481)
- [Webhooks](https://github.com/weaveworks/weave-gitops-enterprise/issues/1487)

## Decision

TBA
As [discussed in RFC](../rfcs/0003-change-detection/README.md) each of approaches has associated unknowns. The major ones were

- Webhooks: the need for a new network flow in the product, from leaf cluster to management, and the impediments
that it would suppose for customers while adopting the solution.
- Watching: how reliable the solution could be as not having existing examples of products using it for watching remote clusters.

We envision that weave gitops needs to be a flexible solution that eventually would need to support both approaches
to accommodate the range of potential enterprises using weave gitops.

In order to start with one of the approaches, we have decided to start by using `webhooks` due to

- allow us to provide promotions for wge customers based on our own promotions capability

but also because

- flux provides the base building blocks to integrate with existing customer's promotion systems. It opens the door
for a gradual adoption of the wge pipeline solution for customers that already have custom delivery logic.


## Consequences

Expand Down

0 comments on commit 914c685

Please sign in to comment.