Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ClustersClientsMiddleware #1600

Closed
Tracked by #1677
luizbafilho opened this issue Mar 3, 2022 · 1 comment · Fixed by #1627
Closed
Tracked by #1677

Implement ClustersClientsMiddleware #1600

luizbafilho opened this issue Mar 3, 2022 · 1 comment · Fixed by #1627
Assignees

Comments

@luizbafilho
Copy link
Contributor

Implement the middleware responsible for fetching the cluster and creating clients for each and injecting them in the context.

That work should be based of #1556

Implementation Notes

  • If no clusters configmap is present, we understand that as running in a non-multi-cluster setup, so just return that single cluster client in the clusters clients' lists
@Callisto13
Copy link
Contributor

Recapping what was discussed in our planning meeting:

  • Multi-cluster is not a feature of core
  • So core cannot have any way to add multiple clusters
  • So we will be doing the multi bit in Enterprise
    • Including all the config map hack bits
  • From core's side we need to:
    • Define the clusters fetcher interface
    • Fulfil that interface by adding a single, in-memory cluster to a pool which is added to the context (basically doing what we do now, but putting the client somewhere else.

More tickets will be coming up for the rest 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants