Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core namespace endpoint to use client pool #1675

Closed
Tracked by #1677
Callisto13 opened this issue Mar 10, 2022 · 3 comments · Fixed by #1888
Closed
Tracked by #1677

Update core namespace endpoint to use client pool #1675

Callisto13 opened this issue Mar 10, 2022 · 3 comments · Fixed by #1888
Assignees

Comments

@Callisto13
Copy link
Contributor

Callisto13 commented Mar 10, 2022

Short description
Following on from #1600 and based on #1556, this is to update the endpoint in core/server/namespace to:

  • Pull a list of clients from the ctx
  • Loop over those and query each

Acceptance criteria
Everything which currently works should still work

@jpellizzari
Copy link
Contributor

This is sort of being worked on in #1725

@Callisto13
Copy link
Contributor Author

Callisto13 commented Mar 28, 2022

I don't think it is exactly. Looks like it is using a single client. But is worth noting that this one should probably wait for #1780 to be merged, just to avoid complications

edit: oh wait I got confused about which ticket this was (either way, it may be easier for you to wait for 1780 before you do 1725)

@yitsushi
Copy link
Contributor

The scope of this ticket changes with my PR on namespace cache (#1780) because I replaced the namespace grpc endpoints to use the cache instead. So it's more like:

update cache/namespace to use client pool, pull and store data respectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants