docs: Update Acceptance policy #4053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yitsushi
reviewed
Oct 2, 2023
| @@ -23,6 +23,11 @@ These things will make a PR more likely to be accepted: | |||
| - tests for old code! | |||
| - new code and tests follow the conventions in old code and tests | |||
| - a good commit message (see below) | |||
| - all code must abide by [Go Code Review Comments](https://github.com/golang/go/wiki/CodeReviewComments) | |||
| - names should abide by [What's in a name](https://talks.golang.org/2014/names.slide#1) | |||
| - code must build on both Linux and Darwin, via plain `go build` | |||
There was a problem hiding this comment.
That's a tricky one to enforce. It makes sense, but as a random person if I try to join to contribute that may make some uncertainties as I have no mac where I can test and build.
There was a problem hiding this comment.
Agreed, this is not meant to be a strict/hard requirement but rather an acknowledgment that a simple go build should be sufficient.
yitsushi
approved these changes
Oct 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Updated Acceptance policy.
Why was this change made?
To make PR requirements more explicit.
How was this change implemented?
N/A
How did you validate the change?
N/A
Release notes
N/A
Documentation Changes
N/A