Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show suspended by annotations to metadata component #4139

Merged
merged 2 commits into from
Nov 21, 2023
Merged

show suspended by annotations to metadata component #4139

merged 2 commits into from
Nov 21, 2023

Conversation

ahussein3
Copy link
Contributor

@ahussein3 ahussein3 commented Nov 20, 2023 •
edited
Loading

Closes #3546

What changed?

  • Refactor suspended by annotations to have prefix "metadata".
  • After adding the prefix metadata that makes the suspended to show up at the metadata component at the details page view

How did you validate the change?

  • Update the Tests

@ahussein3 ahussein3 added the type/enhancement New feature or request label Nov 20, 2023
@ahussein3 ahussein3 requested a review from foot November 20, 2023 12:39
@ahussein3 ahussein3 self-assigned this Nov 20, 2023
@ahussein3 ahussein3 force-pushed the AddSuspendedByAnnotations branch from d5b179a to dc22f17 Compare November 20, 2023 19:11
@ahussein3 ahussein3 changed the title show suspended by annotations to page status component show suspended by annotations to metadata component Nov 20, 2023
@ahussein3 ahussein3 marked this pull request as ready for review November 20, 2023 19:15
@ahussein3 ahussein3 assigned ranatrk and unassigned ranatrk Nov 20, 2023
@ahussein3 ahussein3 requested a review from ranatrk November 20, 2023 19:16
foot
foot approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🙌

@ahussein3 ahussein3 merged commit 654c70d into main Nov 21, 2023
@ahussein3 ahussein3 deleted the AddSuspendedByAnnotations branch November 21, 2023 10:45
@weave-gitops-bot weave-gitops-bot mentioned this pull request Nov 22, 2023
Merged
@weave-gitops-bot weave-gitops-bot mentioned this pull request Jan 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foot foot foot approved these changes

@ranatrk ranatrk Awaiting requested review from ranatrk

Assignees

@ahussein3 ahussein3

Labels
type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahussein3 @foot @ranatrk