Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4157
What changed?
gitops check
command works again.Why was this change made?
--short
flag has been removed fromkubectl version
in 1.28 (https://github.com/kubernetes/kubernetes/blob/7fe31be11fbe9b44af262d5f5cffb1e73648aa96/CHANGELOG/CHANGELOG-1.28.md#deprecation) so the command obviously fails now.How was this change implemented?
This commit changes the behaviour of the
gitops check
command to create a client-go DiscoveryClient and use that to retrieve the server version. That way we don't have to rely on forking akubectl
process and the output being consistent.The code is now much cleaner, easier to read and properly tested.
How did you validate the change?
Unit tests and manual runs.
Release notes
gitops check
command with most recent version ofkubectl
.gitops check
will only yield a positive result if the Kubernetes version is at least 1.26.0.Documentation Changes
n/a