ipam: Do not deref nil in GET /ipinfo/tracker if tracker doesn't exist

In some cases, we do not create any IPAM tracker, which leads to a panic when GET'ing /ipinfo/tracker.
weaveworks · Sep 21, 2018 · 75f6cfc · 75f6cfc
1 parent 1fcd521
commit 75f6cfc
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/ipam/http.go b/ipam/http.go
@@ -199,6 +199,10 @@ func (alloc *Allocator) HandleHTTP(router *mux.Router, defaultSubnet address.CID
 	})
 
 	router.Methods("GET").Path("/ipinfo/tracker").HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		fmt.Fprintf(w, alloc.tracker.String())
+		tracker := ""
+		if alloc.tracker != nil {
+			alloc.tracker.String()
+		}
+		fmt.Fprintf(w, tracker)
 	})
 }