Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

attach containers started with --net=none #1302

Closed
rade opened this issue Aug 14, 2015 · 0 comments
Closed

attach containers started with --net=none #1302

rade opened this issue Aug 14, 2015 · 0 comments
Assignees
@paulbellamy
Labels
chore [component/proxy]
Milestone
1.1.0

Comments

@rade
Copy link
Member

rade commented Aug 14, 2015

The proxy does not attach containers to the weave network when they were started with --net=none. I don't think there is a good reason to prevent that; weave run is perfectly happy to do that. The only issue I can think of is #1301 but that is, well, a separate issue.
@rade rade modified the milestone: current Aug 14, 2015
@paulbellamy paulbellamy self-assigned this Aug 14, 2015
@paulbellamy paulbellamy mentioned this issue Aug 14, 2015
Merged
rade added a commit that referenced this issue Aug 14, 2015
@rade
Merge pull request #1303 from weaveworks/1302-proxy-net-none
9de7c9e 
[proxy] attach containers with --net=none to weave

Fixes #1302.
@rade rade modified the milestone: 1.1.0 Aug 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@paulbellamy paulbellamy

Labels
chore [component/proxy]
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@rade @paulbellamy