Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Unhelpful message on incorrect weave launch option #1321

Closed
bboreham opened this issue Aug 18, 2015 · 0 comments
Closed

Unhelpful message on incorrect weave launch option #1321

bboreham opened this issue Aug 18, 2015 · 0 comments
Assignees
@rade
Labels
bug [component/router]
Milestone
1.1.0

Comments

@bboreham
Copy link
Contributor

Example:

# weave launch -p
The weave container has died. Consult the logs with 'docker logs weave' for further details.
# docker logs weave
flag provided but not defined: -p
See '/home/weave/weaver --help'.

The path /home/weave/weaver is internal to the container, so the user would find it hard to follow this advice.
@bboreham bboreham mentioned this issue Aug 18, 2015
Closed
rade added a commit that referenced this issue Aug 18, 2015
@rade
eliminate misleading flag parsing error
e1feefc 
The standard mflags error reporting produces an error like
```
flag provided but not defined: -p
See '/home/weave/weaver --help'.
```
on stderr. This is misleading since the program name is container
local, so not something the user actually invoked. Furthermore, what
the user *can* invoke doesn't have a `--help` option.

With this change the error becomes
```
FATA: 2015/08/18 10:56:23.635119 Incorrect usage: flag provided but not defined: -p
```

There are a few issues with this:

- we no longer get a usage message
- we no longer get deprecation warnings logged

Fixes #1321.
@rade rade mentioned this issue Aug 18, 2015
Merged
@rade rade self-assigned this Aug 18, 2015
rade added a commit that referenced this issue Aug 20, 2015
@rade
eliminate misleading flag parsing error
bd130f5 
The standard mflags error reporting produces an error like
```
flag provided but not defined: -p
See '/home/weave/weaver --help'.
```
on stderr. This is misleading since the program name is container
local, so not something the user actually invoked. Furthermore, what
the user *can* invoke doesn't have a `--help` option.

With this change the error becomes
```
FATA: 2015/08/18 10:56:23.635119 Incorrect usage: flag provided but not defined: -p
```

There are a few issues with this:

- we no longer get a usage message
- we no longer get deprecation warnings logged

Fixes #1321.
rade added a commit that referenced this issue Aug 20, 2015
@rade
eliminate misleading flag parsing error
fd6d15e 
The standard mflags error reporting produces s.t. like
```
flag provided but not defined: -p
See '/home/weave/weaver --help'.
```
on stderr. This is misleading since the program name is container
local, so not something the user actually invoked.

Fixes #1321.
rade added a commit that referenced this issue Aug 20, 2015
@rade
Merge pull request #1324 from weaveworks/1321_elminate_misleading_fla…
b075e93 
…g_parsing_error

eliminate misleading flag parsing error

Fixes #1321.
@rade rade modified the milestone: 1.1.0 Aug 29, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rade rade

Labels
bug [component/router]
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@rade @bboreham