Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Remove /var/run mount from launch-proxy #1492

Closed
paulbellamy opened this issue Oct 1, 2015 · 1 comment · Fixed by #1495
Closed

Remove /var/run mount from launch-proxy #1492

paulbellamy opened this issue Oct 1, 2015 · 1 comment · Fixed by #1495
Assignees
@paulbellamy
Labels
chore [component/proxy]
Milestone
1.2.0

Comments

@paulbellamy
Copy link
Contributor

Introduced for backwards-compatibility in #1476 (comment)
@paulbellamy paulbellamy added this to the 1.2.0 milestone Oct 1, 2015
@rade
Copy link
Member

rade commented Oct 1, 2015

NB: this does entail

  1. removing the symlinking to /var/run/weave.sock
  2. replacing the /var/run volume mount with just a /var/run/docker.sock volume mount, as we had before

@paulbellamy paulbellamy self-assigned this Oct 1, 2015
@paulbellamy paulbellamy mentioned this issue Oct 1, 2015
Merged
@rade rade closed this as completed in #1495 Oct 1, 2015
rade added a commit that referenced this issue Oct 1, 2015
@rade
Merge pull request #1495 from weaveworks/1492-proxy-remove-var-run-mount
d547829 
Remove /var/run mount from exec_remote. Proxy uses /var/run/weave/weave.sock

Fixes #1492.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@paulbellamy paulbellamy

Labels
chore [component/proxy]
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Remove /var/run mount from exec_remote. Proxy uses /var/run/weave/weave.sock weaveworks/weave
2 participants
@rade @paulbellamy