Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Make veth settings closer to those produced by the weave script #1726

Closed
awh opened this issue Nov 26, 2015 · 7 comments
Closed

Make veth settings closer to those produced by the weave script #1726

awh opened this issue Nov 26, 2015 · 7 comments

Comments

@awh
Copy link
Contributor

awh commented Nov 26, 2015

The weave script does a few things like ethtool tx off that the plugin doesn't currently do.

Most of these are not relevant to FDP, only the "slow" path.

Replaces weaveworks-experiments/docker-plugin#53; see there for additional commentary.

@bboreham
Copy link
Contributor

bboreham commented Dec 2, 2015

Also the weave script adds a multicast route for each container

@bboreham
Copy link
Contributor

Multicast route covered by #1776; ethtool tx off less important now we're mostly not using pcap.

@rade
Copy link
Member

rade commented Dec 22, 2015

ethtool tx off less important now we're mostly not using pcap.

See #1788 for why that is the case.

@rade
Copy link
Member

rade commented Dec 22, 2015

So what is left to do here?

@bboreham
Copy link
Contributor

bboreham commented Jan 7, 2016

The predecessor issue noted "The arp stuff is relevant".

The ethtool point also relates to #1255

@bboreham
Copy link
Contributor

The Docker plugin is not given direct access to the container's namespace (indeed, it is called before the container has started), so adjusting its arp settings requires an indirect approach. We could do it in the same place we add DNS names, i.e. after the container has started.

Note #2030 adds a utility function to do the arp settings.

@bboreham
Copy link
Contributor

bboreham commented May 26, 2016

tx off now implemented by #2307; only arp settings and gratuitous arp remain.

These would have to be done asynchronously by the plugin, after the container starts, because they need to be done in the container's namespace. Docker does not provide a hook to do this.

Also Docker doesn't tell the network driver the IP address in JoinEndpoint.

Probably we can do it at the same time as we do the DNS update; we need to find the container's namespace, enter it, do the arp stuff.

@awh awh closed this as completed in #2374 Jun 17, 2016
awh added a commit that referenced this issue Jun 17, 2016
Perform arp configuration for plugin-connected containers
@awh awh added this to the 1.6.0 milestone Jun 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants