unused vars in 'weave' script

[rade]

according to shellcheck the following vars are unused:

• PROXY_PORT
• WITH_DNS
• IPAM_CIDRs
• CLIENT_TLS_ENABLED

IPAM_CIDRs is just a typo. PROXY_PORT and CLIENT_TLS_ENABLED are probably leftovers. @paulbellamy? WITH_DNS is suspicious, since it corresponds to a documented weave run option.

[paulbellamy]

I believe that PROXY_PORT and CLIENT_TLS_ENABLED are leftovers, yes.

[rade]

I have fixed the IPAM_CIDRs complaint in 20a48f0 and the PROXY_PORT issue in 3909936.

[rade]

The use of CLIENT_TLS_ENABLED got removed in #1679. @awh @paulbellamy. So it's not on 1.3, so not part of this issue. Closing.

[rade]

Closing.

oops, forgot about WITH_DNS. -> re-opening.

[rade]

--with-dns on weave run became non-functional when we merged the dns server into the router container. Yet we still have code and docs for it. We should fix that. NB: doc fix should go on latest_release_doc_updates.

Note that the proxy --with-dns does still do something atm, namely configuring containers to use weavedns even when weave may not be running at the time. I am not convinced this is all that useful. Covered by #1754.