Why does make try to build tools/runner?

[dpw]

With #1861, it is almost possible to checkout weaveworks/weave in an arbitrary location (i.e. not under your GOPATH) and do make.

Almost, but not quite, because it fails while doing make -C tools/runner. But it's not obvious to me why the all target needs to do that anyway (if one considers the point of the default target to be to satisfy the instructions in site/building.md). tools/runner looks like something for circleci, and surely circleci can invoke make with some other target to get what it needs?

If I remove $(RUNNER_EXE) as a dependency of all, then a build succeeds when not under GOPATH.

[dpw]

CC @tomwilkie

[tomwilkie]

Yup we can remove that, but we we surely get complaints for people who try to run the tests manually (@rade). I could add it to the run-smoketests target?

[rade]

I could add it to the run-smoketests target?

Fine, but I don't normally run that; I tend to run ./setup.sh and individual or groups of tests manually. So perhaps also add a pseudo-target for building all that is required to run the smoketests, so I get something more memorable than make tools/runner/runner.

[awh]

So perhaps also add a pseudo-target for building all that is required to run the smoketests

And make run-smoketests depend on that, as I frequently use make all tests run-smoketests.

[rade]

And make run-smoketests depend on that

Exactly. that was the idea.