-
Notifications
You must be signed in to change notification settings - Fork 673
Improve and extend Prometheus metrics #2557
Comments
Additionally, |
This is addressed by #2568 |
@brb @bboreham I am unsure whether I am supposed to open a new issue. This one is quite old and seems to be "resolved" mostly? Anyways: At KubeCon 2018 in Kopenhagen we spoke briefly about the automatic cleanup (rmpeer) of peers when running inside Kubernetes on nodes that are part of an AWS ASG. It would be very nice if you could add a metric / count of the number of peers which were removed due to this mechanism to actively monitor this. @bboreham you suggested to simply raise an issue to request this feature. |
@frittentheke generally it's best to open a new issue; it's easier to deal with accidental duplicates than the other way round. Since this particular issue is a random set of "stuff" I think that's an even better reason to open a new one. |
#2547 has introduced Prometheus metrics for weave-net. Some metrics can be improved though. Suggestions include in no particular order:
weave_{packet,bytes}_total
: remove the"flow"
label.weave_{packet,bytes}_total
: add the"overlay"
label.weave_{packet,bytes}_total{overlay="fastdp"}
: restore and change calculation toflushedFlowsTotal + sum(activeFlows)
as flows get flushed periodically .flushedFlowsTotal
should be updated before flushing flows.prog/weaver/metrics.go
) across parts in the code which metrics are instrumenting (same as logging). Keep only those parts fromprog/weave/metrics.go
which are necessary for actual serving of metrics to Prometheus. The change helps with debugging. Keep in mind, that it changes the internal metrics collection model from pull to push.weave_dns_entries{state="local"} / ignoring(state) weave_dns_entries{state="total"}
vsweave_local_dns_entries / weave_dns_entries
.The text was updated successfully, but these errors were encountered: