Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Go panic in weave container #3184

Closed
berlic opened this issue Nov 22, 2017 · 0 comments
Closed

Go panic in weave container #3184

berlic opened this issue Nov 22, 2017 · 0 comments
Milestone

Comments

@berlic
Copy link
Contributor

berlic commented Nov 22, 2017

What you expected to happen?

Weave container to run smoothly.

What happened?

panic: assignment to entry in nil map

goroutine 82 [running]:
github.com/weaveworks/weave/vendor/github.com/weaveworks/mesh.makeLocalConnectionStatusSlice.func1(0xc421263f40)
    /go/src/github.com/weaveworks/weave/vendor/github.com/weaveworks/mesh/status.go:179 +0x42f
github.com/weaveworks/weave/vendor/github.com/weaveworks/mesh.(*connectionMaker).queryLoop(0xc4212c0620, 0xc42133a300)
    /go/src/github.com/weaveworks/weave/vendor/github.com/weaveworks/mesh/connection_maker.go:228 +0xf6
created by github.com/weaveworks/weave/vendor/github.com/weaveworks/mesh.newConnectionMaker
    /go/src/github.com/weaveworks/weave/vendor/github.com/weaveworks/mesh/connection_maker.go:75 +0x21a

How to reproduce it?

Don't know exact steps. Happens often when we start many (10-15) peers simultaneously.

Anything else we need to know?

Seems that this panic situation was suppressed in weaveworks/mesh#79 but weave 2.0.5 and 2.1.1 still refers to old version of mesh.

Versions:

$ weave version
weave script 2.0.4
weave 2.0.4
$ docker version
Client:
 Version:      17.06.2-ce
 API version:  1.30
 Go version:   go1.8.3
 Git commit:   cec0b72
 Built:        Tue Sep  5 20:00:17 2017
 OS/Arch:      linux/amd64

Server:
 Version:      17.06.2-ce
 API version:  1.30 (minimum version 1.12)
 Go version:   go1.8.3
 Git commit:   cec0b72
 Built:        Tue Sep  5 19:59:11 2017
 OS/Arch:      linux/amd64
 Experimental: false
$ uname -a
Linux Node-3 4.4.0-101-generic #124-Ubuntu SMP Fri Nov 10 18:29:59 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

Logs:

$ docker logs weave
INFO: 2017/11/21 07:34:40.343172 ->[45.63.92.80:6783|fe:3b:45:b1:ea:4b(Call-9)]: connection added (new peer)
INFO: 2017/11/21 07:34:40.343532 ->[104.238.182.129:33934|b6:88:97:c8:d0:ba(Call-8)]: connection added (new peer)
INFO: 2017/11/21 07:34:40.343767 ->[45.63.93.145:59070|d2:b8:0e:ce:de:5a(Call-3)]: connection added (new peer)
INFO: 2017/11/21 07:34:40.343985 ->[104.238.181.46:33251|22:86:72:9c:eb:5c(Call-2)]: connection added (new peer)
INFO: 2017/11/21 07:34:40.344248 ->[45.77.188.54:6783|66:4c:cb:70:8c:b7(Call-6)]: connection added (new peer)
INFO: 2017/11/21 07:34:40.345839 ->[104.238.182.129:6783|b6:88:97:c8:d0:ba(Call-8)]: connection ready; using protocol version 2
panic: assignment to entry in nil map

goroutine 82 [running]:
github.com/weaveworks/weave/vendor/github.com/weaveworks/mesh.makeLocalConnectionStatusSlice.func1(0xc421263f40)
    /go/src/github.com/weaveworks/weave/vendor/github.com/weaveworks/mesh/status.go:179 +0x42f
github.com/weaveworks/weave/vendor/github.com/weaveworks/mesh.(*connectionMaker).queryLoop(0xc4212c0620, 0xc42133a300)
    /go/src/github.com/weaveworks/weave/vendor/github.com/weaveworks/mesh/connection_maker.go:228 +0xf6
created by github.com/weaveworks/weave/vendor/github.com/weaveworks/mesh.newConnectionMaker
    /go/src/github.com/weaveworks/weave/vendor/github.com/weaveworks/mesh/connection_maker.go:75 +0x21a
bboreham added a commit that referenced this issue Nov 27, 2017
@bboreham bboreham added this to the 2.1.2 milestone Nov 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants