Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

don't attempt to connect to remote addresses of inbound connections #448

Closed
rade opened this issue Mar 10, 2015 · 0 comments · Fixed by #451
Closed

don't attempt to connect to remote addresses of inbound connections #448

rade opened this issue Mar 10, 2015 · 0 comments · Fixed by #451
Labels
chore performance
Milestone
0.10.0

Comments

@rade
Copy link
Member

rade commented Mar 10, 2015

Weave peers attempt to connect to all endpoints they learn about through gossip. That includes the remote ends of inbound connections on themselves or other peers. Which is pointless; such connections will never succeed.

We do want to connect to endpoints of any outbound connections, and also to the weave ports of the endpoints of any inbound connections. Only.

The broader connection attempts are simply a consequence of trying to keep the representation and gossip of connection information simple.
@rade rade added the chore label Mar 10, 2015
@bboreham bboreham mentioned this issue Mar 11, 2015
Merged
@bboreham bboreham self-assigned this Mar 11, 2015
@rade rade closed this as completed in #451 Mar 11, 2015
@rade rade removed the in progress label Mar 11, 2015
rade added a commit that referenced this issue Mar 11, 2015
@rade
Merge pull request #451 from bboreham/448_reduce_conns
0d5562a 
Avoid many pointless connection attempts

Fixes #448.
@dpw dpw mentioned this issue Mar 31, 2015
Open
@rade rade modified the milestone: 0.10.0 Apr 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
chore performance
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

Avoid many pointless connection attempts bboreham/weave
2 participants
@rade @bboreham